[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #51 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 321517
  --> https://bugs.webkit.org/attachment.cgi?id=321517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321517&action=review

>>>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2815
>>>> +        RefPtr<Element> assistendElement = &downcast<Element>(*m_assistedNode);
>>> 
>>> Use Ref<Element> instead since we know m_assistedNode is not null at this point.
>> 
>> The method computeAutofillElements is expecting a RefPtr. Would this work if we use a Ref here instead?
> 
> It looks like computeAutofillElements assumes that the start node must exist, since the first thing it does is dereference start. That should probably take a Ref<> or const & instead.

Using a Ref here now.

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:49
>> +static UIKeyboardLoginCredentialsSuggestion *createUIKeyboardLoginCredentialsSuggestion = [NSClassFromString(@"UIKeyboardLoginCredentialsSuggestion") new];
> 
> I think you meant for this to be a static function that returns a new credentials suggestion?

Yep, I updated that to be a static method which returns a new UIKeyboardLoginCredentialsSuggestion object.

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:66
>> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];
> 
> This leaks webView. Do probably want to make this something like:
> 
> auto webView = adoptNS(~)
> 
> ...or alternately, just make sure you -release the webView at the end.

Added [webView release];

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:87
>> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];
> 
> Ditto.

Done.

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:99
>> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];
> 
> Ditto.

Done.

>> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:125
>> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];
> 
> Ditto.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/6399427c/attachment-0001.html>