[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #48 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 321517
  --> https://bugs.webkit.org/attachment.cgi?id=321517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321517&action=review

>> Source/WebCore/editing/ios/AutofillElements.cpp:94
>> +                    return autofillElements;
> 
> Can we just add a private constructor which takes username & password elements,
> and do AutofillElements(previousElement, &inputElement) here?

Yes, good idea. Added.

>> Source/WebCore/editing/ios/AutofillElements.cpp:108
>> +                    return autofillElements;
> 
> Ditto.

Added new constructor call.

>> Source/WebCore/editing/ios/AutofillElements.cpp:122
>> +            }
> 
> Ditto.

Added new constructor call.

>> Source/WebCore/editing/ios/AutofillElements.cpp:137
>> +    }
> 
> Nit: We don't use "this->" in WebKit. Please remove.

Removed "this->".

>> Source/WebKit/Shared/AssistedNodeInformation.h:113
>> +    bool acceptsAutofilledLoginCredentials;
> 
> Please add an initializer: { false }. r- because of this and iOS build failures.

Added initializer.

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2814
>> +    if (is<HTMLInputElement>(m_assistedNode.get())) {
> 
> Use is<HTMLInputElement>(*m_assistedNode) instead.

Done.

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2815
>> +        RefPtr<Element> assistendElement = &downcast<Element>(*m_assistedNode);
> 
> Use Ref<Element> instead since we know m_assistedNode is not null at this point.

The method computeAutofillElements is expecting a RefPtr. Would this work if we use a Ref here instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/939b7b8f/attachment-0001.html>