[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321517|review?                     |review-
              Flags|                            |

--- Comment #47 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 321517
  --> https://bugs.webkit.org/attachment.cgi?id=321517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321517&action=review

> Source/WebCore/editing/ios/AutofillElements.cpp:94
> +                    autofillElements.m_password = &inputElement;
> +                    autofillElements.m_username = previousElement;
> +                    return autofillElements;

Can we just add a private constructor which takes username & password elements,
and do AutofillElements(previousElement, &inputElement) here?

> Source/WebCore/editing/ios/AutofillElements.cpp:108
> +                    autofillElements.m_password = nextElement;
> +                    autofillElements.m_username = &inputElement;
> +                    return autofillElements;

Ditto.

> Source/WebCore/editing/ios/AutofillElements.cpp:122
> +            if (!previousElement && !nextElement) {
> +                autofillElements.m_password = &inputElement;
> +                return autofillElements;
> +            }

Ditto.

> Source/WebCore/editing/ios/AutofillElements.cpp:137
> +    if (this->m_username) {
> +        this->m_username->setValueForUser(username);
> +        this->m_username->setAutoFilled();
> +    }
> +    if (this->m_password) {
> +        this->m_password->setValueForUser(password);
> +        this->m_password->setAutoFilled();
> +    }

Nit: We don't use "this->" in WebKit. Please remove.

> Source/WebKit/Shared/AssistedNodeInformation.h:113
> +    bool acceptsAutofilledLoginCredentials;

Please add an initializer: { false }. r- because of this and iOS build failures.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2814
> +    if (is<HTMLInputElement>(m_assistedNode.get())) {

Use is<HTMLInputElement>(*m_assistedNode) instead.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2815
> +        RefPtr<Element> assistendElement = &downcast<Element>(*m_assistedNode);

Use Ref<Element> instead since we know m_assistedNode is not null at this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/bc19507d/attachment-0001.html>