[Webkit-unassigned] [Bug 169140] WKWebView should provide a way for client's to know the specific media state.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169140

--- Comment #5 from Andrew Gold <agold at apple.com> ---
(In reply to comment #4)
> Comment on attachment 303598 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303598&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        WKWebView should provide a way for client's to know the specific media state.
> 
> No apostrophe.

Oops.

> 
> > Source/WebKit2/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=169140
> 
> Please include the Radar number.

Done.

> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:6455
> > +    if ((oldState & activeCaptureMask) != (m_mediaState & activeCaptureMask))
> 
> Isn't this just `if (oldMediaStateHasActiveCapture !=
> newMediaStateHasActiveCapture)`?

No, because the MediaState may change for reasons other than a capture session beginning or ending (such as when audio/video starts playing).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/caf21928/attachment-0001.html>