[Webkit-unassigned] [Bug 169140] WKWebView should provide a way for client's to know the specific media state.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169140

--- Comment #4 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 303598
  --> https://bugs.webkit.org/attachment.cgi?id=303598
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=303598&action=review

> Source/WebKit2/ChangeLog:3
> +        WKWebView should provide a way for client's to know the specific media state.

No apostrophe.

> Source/WebKit2/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=169140

Please include the Radar number.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:6455
> +    if ((oldState & activeCaptureMask) != (m_mediaState & activeCaptureMask))

Isn't this just `if (oldMediaStateHasActiveCapture != newMediaStateHasActiveCapture)`?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/2e22e7b9/attachment-0001.html>