<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WKWebView should provide a way for client's to know the specific media state."
href="https://bugs.webkit.org/show_bug.cgi?id=169140#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WKWebView should provide a way for client's to know the specific media state."
href="https://bugs.webkit.org/show_bug.cgi?id=169140">bug 169140</a>
from <span class="vcard"><a class="email" href="mailto:agold@apple.com" title="Andrew Gold <agold@apple.com>"> <span class="fn">Andrew Gold</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=169140#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=303598&action=diff" name="attach_303598" title="Proposed patch.">attachment 303598</a> <a href="attachment.cgi?id=303598&action=edit" title="Proposed patch.">[details]</a></span>
> Proposed patch.
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=303598&action=review">https://bugs.webkit.org/attachment.cgi?id=303598&action=review</a>
>
> > Source/WebKit2/ChangeLog:3
> > + WKWebView should provide a way for client's to know the specific media state.
>
> No apostrophe.</span >
Oops.
<span class="quote">>
> > Source/WebKit2/ChangeLog:4
> > + <a class="bz_bug_link
bz_status_NEW "
title="NEW - WKWebView should provide a way for client's to know the specific media state."
href="show_bug.cgi?id=169140">https://bugs.webkit.org/show_bug.cgi?id=169140</a>
>
> Please include the Radar number.</span >
Done.
<span class="quote">>
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:6455
> > + if ((oldState & activeCaptureMask) != (m_mediaState & activeCaptureMask))
>
> Isn't this just `if (oldMediaStateHasActiveCapture !=
> newMediaStateHasActiveCapture)`?</span >
No, because the MediaState may change for reasons other than a capture session beginning or ending (such as when audio/video starts playing).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>