[Webkit-unassigned] [Bug 173145] Add API::IconDatabaseClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 09:59:28 PDT 2017


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
 Attachment #312418|review-                     |review+
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312418
  --> https://bugs.webkit.org/attachment.cgi?id=312418

View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review

> Source/WebKit2/UIProcess/API/APIIconDatabaseClient.h:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.


>>> Source/WebKit2/UIProcess/WebIconDatabase.h:118
>>> +    std::unique_ptr<API::IconDatabaseClient> m_client;
>> I think this is wrong.  Usually we have the API object own the WebKit namespace object.
> Could you point to an example? I think I've followed what all other objects do. 
>  - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients
>  - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient
> or did I misunderstand what you mean?

After talking to some people, I now think this is correct.  Sorry about the misunderstanding.  API namespace objects own WebKit namespace objects, but clients pass calls in the opposite direction.  This is correct.
We should us a UniqueRef here because it's never null.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/7b1f5d69/attachment.html>

More information about the webkit-unassigned mailing list