[Webkit-unassigned] [Bug 173145] Add API::IconDatabaseClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173145

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 312418
  --> https://bugs.webkit.org/attachment.cgi?id=312418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review

>> Source/WebKit2/UIProcess/WebIconDatabase.h:118
>> +    std::unique_ptr<API::IconDatabaseClient> m_client;
> 
> I think this is wrong.  Usually we have the API object own the WebKit namespace object.

Could you point to an example? I think I've followed what all other objects do. 

 - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients
 - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient

or did I misunderstand what you mean?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170610/1917d484/attachment-0001.html>