[Webkit-unassigned] [Bug 173145] Add API::IconDatabaseClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173145

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #4)
> Comment on attachment 312418 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312418&action=review
> 
> > Source/WebKit2/UIProcess/API/APIIconDatabaseClient.h:2
> > + * Copyright (C) 2014 Apple Inc. All rights reserved.
> 
> 2017
> 
> >>> Source/WebKit2/UIProcess/WebIconDatabase.h:118
> >>> +    std::unique_ptr<API::IconDatabaseClient> m_client;
> >> 
> >> I think this is wrong.  Usually we have the API object own the WebKit namespace object.
> > 
> > Could you point to an example? I think I've followed what all other objects do. 
> > 
> >  - WebPageProxy in WebKit namespace owns API::LoaderClient, API::PolicyClient, API::NavigationClient, and a lot more clients
> >  - WebProcessPool in WebKit namespace owns API::AutomationClient, API::DownloadClient, API::LegacyContextHistoryClient and API::CustomProtocolManagerClient
> > 
> > or did I misunderstand what you mean?
> 
> After talking to some people, I now think this is correct.  Sorry about the
> misunderstanding.

np, the whole thing is indeed confusing at first.

>  API namespace objects own WebKit namespace objects, but
> clients pass calls in the opposite direction.  This is correct.
> We should us a UniqueRef here because it's never null.

Didn't know UniqueRef, do you want me to change this patch before landing to use UniqueRef, or better do that in a follow up and switch all clients to UniqueRef?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/e589379e/attachment-0001.html>