[Webkit-unassigned] [Bug 167415] Avoid evicting link preload resources when parsing is done.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 13:02:56 PST 2017


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #299919|review?                     |review+
              Flags|                            |

--- Comment #28 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 299919
  --> https://bugs.webkit.org/attachment.cgi?id=299919

View in context: https://bugs.webkit.org/attachment.cgi?id=299919&action=review

I think the current approach is fine. CachedResource is supposed to encapsulate these things anyway.
We do have a lot of indications and weird class hierarchy in the loading code through.
Instead of adding a new class, we should consider refactoring them into a more coherent set.

> Source/WebCore/dom/Document.cpp:5047
> +    // Parser should have picked up all speculative preloads by now
> +    m_cachedResourceLoader->clearPreloads(CachedResourceLoader::ClearPreloadsMode::ClearSpeculativePreloads);

We never call this function anywhere else e.g. for link element's preload.
Can't we just rename this function to clearSpeculativePreloads instead?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170131/f905f227/attachment.html>

More information about the webkit-unassigned mailing list