<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Avoid evicting link preload resources when parsing is done."
href="https://bugs.webkit.org/show_bug.cgi?id=167415">bug 167415</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299919 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Avoid evicting link preload resources when parsing is done."
href="https://bugs.webkit.org/show_bug.cgi?id=167415#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Avoid evicting link preload resources when parsing is done."
href="https://bugs.webkit.org/show_bug.cgi?id=167415">bug 167415</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299919&action=diff" name="attach_299919" title="Patch">attachment 299919</a> <a href="attachment.cgi?id=299919&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299919&action=review">https://bugs.webkit.org/attachment.cgi?id=299919&action=review</a>
I think the current approach is fine. CachedResource is supposed to encapsulate these things anyway.
We do have a lot of indications and weird class hierarchy in the loading code through.
Instead of adding a new class, we should consider refactoring them into a more coherent set.
<span class="quote">> Source/WebCore/dom/Document.cpp:5047
> + // Parser should have picked up all speculative preloads by now
> + m_cachedResourceLoader->clearPreloads(CachedResourceLoader::ClearPreloadsMode::ClearSpeculativePreloads);</span >
We never call this function anywhere else e.g. for link element's preload.
Can't we just rename this function to clearSpeculativePreloads instead?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>