[Webkit-unassigned] [Bug 167415] Avoid evicting link preload resources when parsing is done.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167415

--- Comment #29 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to comment #28)
> Comment on attachment 299919 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299919&action=review
> 
> I think the current approach is fine. CachedResource is supposed to
> encapsulate these things anyway.
> We do have a lot of indications and weird class hierarchy in the loading
> code through.
> Instead of adding a new class, we should consider refactoring them into a
> more coherent set.
> 
> > Source/WebCore/dom/Document.cpp:5047
> > +    // Parser should have picked up all speculative preloads by now
> > +    m_cachedResourceLoader->clearPreloads(CachedResourceLoader::ClearPreloadsMode::ClearSpeculativePreloads);
> 
> We never call this function anywhere else e.g. for link element's preload.
> Can't we just rename this function to clearSpeculativePreloads instead?

It's also called in CachedResourceLoader's destructor (where all preloads are cleared)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170131/96f2362c/attachment.html>