[Webkit-unassigned] [Bug 165319] [mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 05:15:36 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=165319

--- Comment #5 from Antoine Quint <graouts at apple.com> ---
AnimationControllerPrivate::suspendAnimations() suspends animations in the current frame's document and its associated subframes, but also sets a global ivar to prevent further animations until AnimationControllerPrivate::resumeAnimations() is called:

void AnimationControllerPrivate::suspendAnimations()
{
    if (isSuspended())
        return;

    suspendAnimationsForDocument(m_frame.document());

    // Traverse subframes
    for (Frame* child = m_frame.tree().firstChild(); child; child = child->tree().nextSibling())
        child->animation().suspendAnimations();

    m_isSuspended = true;
}

The m_isSuspended flag was added for https://bugs.webkit.org/show_bug.cgi?id=114915.

I think the internals method should not call directly into AnimationControllerPrivate::suspendAnimations() like it does now, but rather suspend animations for the current document like it used to pre-114915.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170131/9e3564a5/attachment.html>


More information about the webkit-unassigned mailing list