<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout"
href="https://bugs.webkit.org/show_bug.cgi?id=165319#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout"
href="https://bugs.webkit.org/show_bug.cgi?id=165319">bug 165319</a>
from <span class="vcard"><a class="email" href="mailto:graouts@apple.com" title="Antoine Quint <graouts@apple.com>"> <span class="fn">Antoine Quint</span></a>
</span></b>
<pre>AnimationControllerPrivate::suspendAnimations() suspends animations in the current frame's document and its associated subframes, but also sets a global ivar to prevent further animations until AnimationControllerPrivate::resumeAnimations() is called:
void AnimationControllerPrivate::suspendAnimations()
{
if (isSuspended())
return;
suspendAnimationsForDocument(m_frame.document());
// Traverse subframes
for (Frame* child = m_frame.tree().firstChild(); child; child = child->tree().nextSibling())
child->animation().suspendAnimations();
m_isSuspended = true;
}
The m_isSuspended flag was added for <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Animations and Transitions should not start when globally suspended"
href="show_bug.cgi?id=114915">https://bugs.webkit.org/show_bug.cgi?id=114915</a>.
I think the internals method should not call directly into AnimationControllerPrivate::suspendAnimations() like it does now, but rather suspend animations for the current document like it used to pre-114915.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>