[Webkit-unassigned] [Bug 167390] Notify clients when the user plays media otherwise prevented from autoplaying

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167390

--- Comment #5 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #4)
> Comment on attachment 299644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299644&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.messages.in:441
> > +    DidPlayMediaPreventedFromPlayingWithoutUserGesture()
> 
> This name is a bit verbose, but I can't think of anything better.
> 
> > Tools/TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:5
> > +                setTimeout(function() {
> 
> Could we remove this setTimeout?

Done.

> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:217
> > +TEST(WebKit2, WebsitePoliciesPlayAfterPreventedAutoplay)
> 
> It would be good to test that a video that shouldn't autoplay doesn't call
> the didPlayMediaPreventedFromPlayingWithoutUserGesture when you play it.

I'll add one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170126/6cf85422/attachment-0001.html>