<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Notify clients when the user plays media otherwise prevented from autoplaying"
href="https://bugs.webkit.org/show_bug.cgi?id=167390#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Notify clients when the user plays media otherwise prevented from autoplaying"
href="https://bugs.webkit.org/show_bug.cgi?id=167390">bug 167390</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=167390#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=299644&action=diff" name="attach_299644" title="Patch">attachment 299644</a> <a href="attachment.cgi?id=299644&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=299644&action=review">https://bugs.webkit.org/attachment.cgi?id=299644&action=review</a>
>
> > Source/WebKit2/UIProcess/WebPageProxy.messages.in:441
> > + DidPlayMediaPreventedFromPlayingWithoutUserGesture()
>
> This name is a bit verbose, but I can't think of anything better.
>
> > Tools/TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:5
> > + setTimeout(function() {
>
> Could we remove this setTimeout?</span >
Done.
<span class="quote">>
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:217
> > +TEST(WebKit2, WebsitePoliciesPlayAfterPreventedAutoplay)
>
> It would be good to test that a video that shouldn't autoplay doesn't call
> the didPlayMediaPreventedFromPlayingWithoutUserGesture when you play it.</span >
I'll add one.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>