[Webkit-unassigned] [Bug 167390] Notify clients when the user plays media otherwise prevented from autoplaying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 15:37:10 PST 2017


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 299644
  --> https://bugs.webkit.org/attachment.cgi?id=299644

View in context: https://bugs.webkit.org/attachment.cgi?id=299644&action=review

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:441
> +    DidPlayMediaPreventedFromPlayingWithoutUserGesture()

This name is a bit verbose, but I can't think of anything better.

> Tools/TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:5
> +                setTimeout(function() {

Could we remove this setTimeout?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:217
> +TEST(WebKit2, WebsitePoliciesPlayAfterPreventedAutoplay)

It would be good to test that a video that shouldn't autoplay doesn't call the didPlayMediaPreventedFromPlayingWithoutUserGesture when you play it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170125/1a76a838/attachment.html>

More information about the webkit-unassigned mailing list