[Webkit-unassigned] [Bug 167236] [SOUP] Custom protocols don't work in private browsing mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 02:29:46 PST 2017


--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 299336
  --> https://bugs.webkit.org/attachment.cgi?id=299336

View in context: https://bugs.webkit.org/attachment.cgi?id=299336&action=review

Didn't want to add tests depending on the soon deprecated private browsing setting, I'll add more unit tests when we add the new API for private browsing.

>> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:304
>> +        return;
> I guess you add this for extra safety as we're asserting above. Not sure we need it but no strong feelings.

No, this is in case setCustomProtocolRequestType hasn't been called, like in the web process. It's true that in that case the type is 0, so we could just check if !type, but yes, added the type check for extra safety

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170120/cffcaa07/attachment.html>

More information about the webkit-unassigned mailing list