[Webkit-unassigned] [Bug 167236] [SOUP] Custom protocols don't work in private browsing mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167236

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299336|review?                     |review+
              Flags|                            |

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 299336
  --> https://bugs.webkit.org/attachment.cgi?id=299336
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299336&action=review

r+ but we need a test to verify that we don't regress

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:304
> +        return;

I guess you add this for extra safety as we're asserting above. Not sure we need it but no strong feelings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170120/9d7adca5/attachment-0001.html>