<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Custom protocols don't work in private browsing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=167236#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Custom protocols don't work in private browsing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=167236">bug 167236</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299336&action=diff" name="attach_299336" title="Patch">attachment 299336</a> <a href="attachment.cgi?id=299336&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299336&action=review">https://bugs.webkit.org/attachment.cgi?id=299336&action=review</a>
Didn't want to add tests depending on the soon deprecated private browsing setting, I'll add more unit tests when we add the new API for private browsing.
<span class="quote">>> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:304
>> + return;
>
> I guess you add this for extra safety as we're asserting above. Not sure we need it but no strong feelings.</span >
No, this is in case setCustomProtocolRequestType hasn't been called, like in the web process. It's true that in that case the type is 0, so we could just check if !type, but yes, added the type check for extra safety</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>