<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Custom protocols don't work in private browsing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=167236">bug 167236</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299336 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Custom protocols don't work in private browsing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=167236#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Custom protocols don't work in private browsing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=167236">bug 167236</a>
from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299336&action=diff" name="attach_299336" title="Patch">attachment 299336</a> <a href="attachment.cgi?id=299336&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299336&action=review">https://bugs.webkit.org/attachment.cgi?id=299336&action=review</a>
r+ but we need a test to verify that we don't regress
<span class="quote">> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:304
> + return;</span >
I guess you add this for extra safety as we're asserting above. Not sure we need it but no strong feelings.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>