[Webkit-unassigned] [Bug 163159] [GTK] Crash attempting to load Flash plugin in Wayland

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163159

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 302393 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302393&action=review
> 
> As I said, it surely also requires an early return in
> WebPageProxy::CreatePluginContainer.

No, it will never reach there, now that the bug is fixed.

> > Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:80
> > +            if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)
> 
> The check should be if type != X11, not if type == Wayland. I know that
> makes the conditionals come out less-cleanly, but let's do it right.

Nope, I'm not sure if it's possible but if you build with wayland and X11 disabled, you can't do that, because Type::X11 is not defined.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170222/65e7c66c/attachment.html>