[Webkit-unassigned] [Bug 163159] [GTK] Crash attempting to load Flash plugin in Wayland

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 07:55:33 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=163159

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 302393
  --> https://bugs.webkit.org/attachment.cgi?id=302393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302393&action=review

As I said, it surely also requires an early return in WebPageProxy::CreatePluginContainer.

> Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:80
> +            if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)

The check should be if type != X11, not if type == Wayland. I know that makes the conditionals come out less-cleanly, but let's do it right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170222/df3e9ab2/attachment.html>


More information about the webkit-unassigned mailing list