<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash attempting to load Flash plugin in Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=163159">bug 163159</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash attempting to load Flash plugin in Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=163159#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash attempting to load Flash plugin in Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=163159">bug 163159</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163159#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=302393&action=diff" name="attach_302393" title="Patch">attachment 302393</a> <a href="attachment.cgi?id=302393&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=302393&action=review">https://bugs.webkit.org/attachment.cgi?id=302393&action=review</a>
>
> As I said, it surely also requires an early return in
> WebPageProxy::CreatePluginContainer.</span >
No, it will never reach there, now that the bug is fixed.
<span class="quote">> > Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:80
> > + if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)
>
> The check should be if type != X11, not if type == Wayland. I know that
> makes the conditionals come out less-cleanly, but let's do it right.</span >
Nope, I'm not sure if it's possible but if you build with wayland and X11 disabled, you can't do that, because Type::X11 is not defined.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>