[Webkit-unassigned] [Bug 168361] Handle EINTR during webkitpy server process select()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 03:00:43 PST 2017


--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 301600
  --> https://bugs.webkit.org/attachment.cgi?id=301600

View in context: https://bugs.webkit.org/attachment.cgi?id=301600&action=review

(Note: This is an informal review)

Just a small nit, otherwise it looks fine.

> Tools/Scripts/webkitpy/port/server_process.py:250
> +            if e.args[0] in [errno.EINVAL, errno.EINTR]:

I would use a tuple here, i.e:

   if e.args[0] in (errno.EINVAL, errno.EINTR):

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170216/187aff94/attachment.html>

More information about the webkit-unassigned mailing list