<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Handle EINTR during webkitpy server process select()"
href="https://bugs.webkit.org/show_bug.cgi?id=168361#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Handle EINTR during webkitpy server process select()"
href="https://bugs.webkit.org/show_bug.cgi?id=168361">bug 168361</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez <aperez@igalia.com>"> <span class="fn">Adrian Perez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301600&action=diff" name="attach_301600" title="Patch">attachment 301600</a> <a href="attachment.cgi?id=301600&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301600&action=review">https://bugs.webkit.org/attachment.cgi?id=301600&action=review</a>
(Note: This is an informal review)
Just a small nit, otherwise it looks fine.
<span class="quote">> Tools/Scripts/webkitpy/port/server_process.py:250
> + if e.args[0] in [errno.EINVAL, errno.EINTR]:</span >
I would use a tuple here, i.e:
if e.args[0] in (errno.EINVAL, errno.EINTR):</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>