[Webkit-unassigned] [Bug 168361] Handle EINTR during webkitpy server process select()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 04:46:57 PST 2017


--- Comment #3 from Florian Bruhin <webkit.org at the-compiler.org> ---
>> Tools/Scripts/webkitpy/port/server_process.py:250
>> +            if e.args[0] in [errno.EINVAL, errno.EINTR]:
> I would use a tuple here, i.e:
>   if e.args[0] in (errno.EINVAL, errno.EINTR):

I'm curious - why? I view a tuple mostly as structured heterogeneous collections of data where the order/length matter (e.g., a (name, age) tuple), and a list as a collection of heterogeneous collection (i.e. a list of error numbers, like here).

If this is about tuples being immutable, that doesn't really matter much IMHO when used as literals like here.

FWIW I'm happy to change it, but I'd like to understand why :-)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170216/25e5c219/attachment.html>

More information about the webkit-unassigned mailing list