[Webkit-unassigned] [Bug 167776] REGRESSION(r211486) [GTK] The MiniBrowser doesn't work anymore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167776

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 300506 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300506&action=review
> 
> r=me with the future refactoring proposal.
> 
> > Source/WebKit2/Shared/WebKit2Initialize.cpp:56
> > +    JSC::initializeThreading();
> 
> It's strange to me that we need to care these ordering.
> Why not calling RunLoop::initializeMainRunLoop() in
> WTF::initializeMainThread?

That was my plan, but then I need to check all the callers, and this is serious, so better fix it soon.

> And why not calling WTF::initializeThreading and WTF::initializeMainThread
> in JSC::initializeThreading?
> By using std::call_once, we can avoid the case that these functions are
> called more than once.
> And after such a refactoring, I think just calling
> JSC::initializeThreading() here is OK.

Yes, there are many things quite fragile in all threading initializations. I'm going to review all of them and all the callers and try a new simpler approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170203/4a26444c/attachment.html>