[Webkit-unassigned] [Bug 167776] REGRESSION(r211486) [GTK] The MiniBrowser doesn't work anymore.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 3 04:04:12 PST 2017
https://bugs.webkit.org/show_bug.cgi?id=167776
Yusuke Suzuki <utatane.tea at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #300506|review? |review+
Flags| |
--- Comment #5 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 300506
--> https://bugs.webkit.org/attachment.cgi?id=300506
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=300506&action=review
r=me with the future refactoring proposal.
> Source/WebKit2/Shared/WebKit2Initialize.cpp:56
> + JSC::initializeThreading();
It's strange to me that we need to care these ordering.
Why not calling RunLoop::initializeMainRunLoop() in WTF::initializeMainThread?
And why not calling WTF::initializeThreading and WTF::initializeMainThread in JSC::initializeThreading?
By using std::call_once, we can avoid the case that these functions are called more than once.
And after such a refactoring, I think just calling JSC::initializeThreading() here is OK.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170203/347a517e/attachment-0001.html>
More information about the webkit-unassigned
mailing list