<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r211486) [GTK] The MiniBrowser doesn't work anymore."
href="https://bugs.webkit.org/show_bug.cgi?id=167776#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r211486) [GTK] The MiniBrowser doesn't work anymore."
href="https://bugs.webkit.org/show_bug.cgi?id=167776">bug 167776</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=167776#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=300506&action=diff" name="attach_300506" title="Patch">attachment 300506</a> <a href="attachment.cgi?id=300506&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=300506&action=review">https://bugs.webkit.org/attachment.cgi?id=300506&action=review</a>
>
> r=me with the future refactoring proposal.
>
> > Source/WebKit2/Shared/WebKit2Initialize.cpp:56
> > + JSC::initializeThreading();
>
> It's strange to me that we need to care these ordering.
> Why not calling RunLoop::initializeMainRunLoop() in
> WTF::initializeMainThread?</span >
That was my plan, but then I need to check all the callers, and this is serious, so better fix it soon.
<span class="quote">> And why not calling WTF::initializeThreading and WTF::initializeMainThread
> in JSC::initializeThreading?
> By using std::call_once, we can avoid the case that these functions are
> called more than once.
> And after such a refactoring, I think just calling
> JSC::initializeThreading() here is OK.</span >
Yes, there are many things quite fragile in all threading initializations. I'm going to review all of them and all the callers and try a new simpler approach.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>