[Webkit-unassigned] [Bug 170058] [SOUP] URI Fragment is lost after redirect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 01:05:17 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170058

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Sergio Villar Senin from comment #11)
> Comment on attachment 306070 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306070&action=review
> 
> > LayoutTests/http/tests/navigation/redirect-preserves-fragment.html:3
> > +<head>
> 
> No need for <html>, <head> and <body> tags when specifying the DOCTYPE. Same
> for the other tests.

I copy-pasted it from existing tests, that what I usually do, since I don't know html, css, js :-P

> > Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:107
> > +    m_currentRequest = WTFMove(request);
> 
> Not a big fan of adding another element to the internal state of the object.

Do you have a better proposal? This is done by NetworkLoad, which could be our client, we could add currentRequest() to the client interface, but I'm not sure it's worth it, TBH.

> Also we're doing additional changes of behaviour here in case of multiple
> redirections because you are no longer using the first request for several
> checks.

That's what fixes bug #158420 for us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170404/f6e73280/attachment-0001.html>


More information about the webkit-unassigned mailing list