<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [SOUP] URI Fragment is lost after redirect"
href="https://bugs.webkit.org/show_bug.cgi?id=170058#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [SOUP] URI Fragment is lost after redirect"
href="https://bugs.webkit.org/show_bug.cgi?id=170058">bug 170058</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to Sergio Villar Senin from <a href="show_bug.cgi?id=170058#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=306070&action=diff" name="attach_306070" title="Patch">attachment 306070</a> <a href="attachment.cgi?id=306070&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=306070&action=review">https://bugs.webkit.org/attachment.cgi?id=306070&action=review</a>
>
> > LayoutTests/http/tests/navigation/redirect-preserves-fragment.html:3
> > +<head>
>
> No need for <html>, <head> and <body> tags when specifying the DOCTYPE. Same
> for the other tests.</span >
I copy-pasted it from existing tests, that what I usually do, since I don't know html, css, js :-P
<span class="quote">> > Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:107
> > + m_currentRequest = WTFMove(request);
>
> Not a big fan of adding another element to the internal state of the object.</span >
Do you have a better proposal? This is done by NetworkLoad, which could be our client, we could add currentRequest() to the client interface, but I'm not sure it's worth it, TBH.
<span class="quote">> Also we're doing additional changes of behaviour here in case of multiple
> redirections because you are no longer using the first request for several
> checks.</span >
That's what fixes <a class="bz_bug_link
bz_status_NEW "
title="NEW - URI fragment of location header not appended in case of further redirect"
href="show_bug.cgi?id=158420">bug #158420</a> for us.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>