[Webkit-unassigned] [Bug 170058] [SOUP] URI Fragment is lost after redirect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 4 01:00:05 PDT 2017


--- Comment #11 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 306070
  --> https://bugs.webkit.org/attachment.cgi?id=306070

View in context: https://bugs.webkit.org/attachment.cgi?id=306070&action=review

> LayoutTests/http/tests/navigation/redirect-preserves-fragment.html:3
> +<head>

No need for <html>, <head> and <body> tags when specifying the DOCTYPE. Same for the other tests.

> Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:107
> +    m_currentRequest = WTFMove(request);

Not a big fan of adding another element to the internal state of the object.

Also we're doing additional changes of behaviour here in case of multiple redirections because you are no longer using the first request for several checks.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170404/c329385d/attachment.html>

More information about the webkit-unassigned mailing list