[Webkit-unassigned] [Bug 162606] Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162606

Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289936|                            |review?
              Flags|                            |

--- Comment #3 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 289936
  --> https://bugs.webkit.org/attachment.cgi?id=289936&action=review
Patch proposal

(In reply to comment #2)
> Comment on attachment 289935 [details]
> Patch proposal
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289935&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:260
> > -#elif PLATFORM(WAYLAND)
> > -        m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
> > +#elif USE(EGL)
> > +        m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));
> 
> Now we're missing the Wayland case? I guess you should start with
> PLATFORM(WAYLAND) and elif USE(GLX), elif USE(EGL)?

I'm an idiot. Forgot about the downcasting, see the new patch now

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/2a0500ba/attachment-0001.html>