[Webkit-unassigned] [Bug 162606] Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 05:35:16 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162606

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289935|review+                     |review-
              Flags|                            |

--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org> ---
Comment on attachment 289935
  --> https://bugs.webkit.org/attachment.cgi?id=289935
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=289935&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:260
> -#elif PLATFORM(WAYLAND)
> -        m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
> +#elif USE(EGL)
> +        m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));

Now we're missing the Wayland case? I guess you should start with PLATFORM(WAYLAND) and elif USE(GLX), elif USE(EGL)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/31239fa8/attachment.html>


More information about the webkit-unassigned mailing list