<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mario@webkit.org" title="Mario Sanchez Prada <mario@webkit.org>"> <span class="fn">Mario Sanchez Prada</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()"
href="https://bugs.webkit.org/show_bug.cgi?id=162606">bug 162606</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289936 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()"
href="https://bugs.webkit.org/show_bug.cgi?id=162606#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()"
href="https://bugs.webkit.org/show_bug.cgi?id=162606">bug 162606</a>
from <span class="vcard"><a class="email" href="mailto:mario@webkit.org" title="Mario Sanchez Prada <mario@webkit.org>"> <span class="fn">Mario Sanchez Prada</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=289936&action=diff" name="attach_289936" title="Patch proposal">attachment 289936</a> <a href="attachment.cgi?id=289936&action=edit" title="Patch proposal">[details]</a></span>
Patch proposal
(In reply to <a href="show_bug.cgi?id=162606#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=289935&action=diff" name="attach_289935" title="Patch proposal">attachment 289935</a> <a href="attachment.cgi?id=289935&action=edit" title="Patch proposal">[details]</a></span>
> Patch proposal
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=289935&action=review">https://bugs.webkit.org/attachment.cgi?id=289935&action=review</a>
>
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:260
> > -#elif PLATFORM(WAYLAND)
> > - m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
> > +#elif USE(EGL)
> > + m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));
>
> Now we're missing the Wayland case? I guess you should start with
> PLATFORM(WAYLAND) and elif USE(GLX), elif USE(EGL)?</span >
I'm an idiot. Forgot about the downcasting, see the new patch now</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>