[Webkit-unassigned] [Bug 163777] NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163777

--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #16)
> Comment on attachment 292600 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292600&action=review
> 
> This is such a huge improvement.  Thanks Carlos! r=me
> 
> > Source/WebKit2/NetworkProcess/NetworkSession.cpp:62
> > +    ASSERT(isMainThread());
> 
> Let's put this assertion outside the #if PLATFORM?

I didn't add the assert for cocoa because NetworkSessionCocoa::defaultSession() already has that assert. It's unfortunate that this code can't be common, maybe we can find a different way to handle the custom protocol manager in cocoa that doesn't require passing it to the constructor.

> > Source/WebKit2/NetworkProcess/NetworkSession.h:49
> > +    virtual void invalidateAndCancel() { };
> > +    virtual void clearCredentials() { };
> 
> These should be purely virtual.  Put notImplemented() in Soup's. 
> clearCredentials isn't used yet, but I hope to use it sometime soon.

invalidateAndCancel() should probably be implemented by all implementations, but clearCredentials is different, I'm thinking in blobs for example that I already started to move to network data task btw.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161025/61b26154/attachment.html>