<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=163777#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=163777">bug 163777</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163777#c16">comment #16</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=292600&action=diff" name="attach_292600" title="Patch">attachment 292600</a> <a href="attachment.cgi?id=292600&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=292600&action=review">https://bugs.webkit.org/attachment.cgi?id=292600&action=review</a>
>
> This is such a huge improvement. Thanks Carlos! r=me
>
> > Source/WebKit2/NetworkProcess/NetworkSession.cpp:62
> > + ASSERT(isMainThread());
>
> Let's put this assertion outside the #if PLATFORM?</span >
I didn't add the assert for cocoa because NetworkSessionCocoa::defaultSession() already has that assert. It's unfortunate that this code can't be common, maybe we can find a different way to handle the custom protocol manager in cocoa that doesn't require passing it to the constructor.
<span class="quote">> > Source/WebKit2/NetworkProcess/NetworkSession.h:49
> > + virtual void invalidateAndCancel() { };
> > + virtual void clearCredentials() { };
>
> These should be purely virtual. Put notImplemented() in Soup's.
> clearCredentials isn't used yet, but I hope to use it sometime soon.</span >
invalidateAndCancel() should probably be implemented by all implementations, but clearCredentials is different, I'm thinking in blobs for example that I already started to move to network data task btw.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>