[Webkit-unassigned] [Bug 163777] NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163777

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292600|review?                     |review+
              Flags|                            |

--- Comment #16 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 292600
  --> https://bugs.webkit.org/attachment.cgi?id=292600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292600&action=review

This is such a huge improvement.  Thanks Carlos! r=me

> Source/WebKit2/NetworkProcess/NetworkSession.cpp:62
> +    ASSERT(isMainThread());

Let's put this assertion outside the #if PLATFORM?

> Source/WebKit2/NetworkProcess/NetworkSession.h:49
> +    virtual void invalidateAndCancel() { };
> +    virtual void clearCredentials() { };

These should be purely virtual.  Put notImplemented() in Soup's.  clearCredentials isn't used yet, but I hope to use it sometime soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161025/ac27ec84/attachment.html>