<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=163777">bug 163777</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #292600 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=163777#c16">Comment # 16</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
   href="https://bugs.webkit.org/show_bug.cgi?id=163777">bug 163777</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=292600&amp;action=diff" name="attach_292600" title="Patch">attachment 292600</a> <a href="attachment.cgi?id=292600&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=292600&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=292600&amp;action=review</a>

This is such a huge improvement.  Thanks Carlos! r=me

<span class="quote">&gt; Source/WebKit2/NetworkProcess/NetworkSession.cpp:62
&gt; +    ASSERT(isMainThread());</span >

Let's put this assertion outside the #if PLATFORM?

<span class="quote">&gt; Source/WebKit2/NetworkProcess/NetworkSession.h:49
&gt; +    virtual void invalidateAndCancel() { };
&gt; +    virtual void clearCredentials() { };</span >

These should be purely virtual.  Put notImplemented() in Soup's.  clearCredentials isn't used yet, but I hope to use it sometime soon.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>