[Webkit-unassigned] [Bug 163777] NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163777

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #12)
> > I think these overrides should remain private.
> 
> I'm curious about your desire for this. This is an idiom that I've not seen
> used before. It seems to me that it could be problematic (for instance, the
> actual compilation problem I encountered). Others seem to feel the same way:
> <http://stackoverflow.com/questions/484592/overriding-public-virtual-
> functions-with-private-functions-in-c>. That article (in part) refers to
> <https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public>.
> 
> So how do you come down on the opposite side of these opinions? What's being
> communicated by making public methods private in the derived class?

In this particular case those methods are pure virtual an expected to be used by NetworkDataTask users who don't know about Soup/Cocoa implementations. Those overrides are providing the implementation for the base class. I'm pretty sure we do this in WebKit, but still, I don't have a strong opinion, we can make them public if you think it's better solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161024/95ded6ea/attachment-0001.html>