[Webkit-unassigned] [Bug 163777] NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163777

--- Comment #12 from Keith Rollin <krollin at apple.com> ---
> I think these overrides should remain private.

I'm curious about your desire for this. This is an idiom that I've not seen used before. It seems to me that it could be problematic (for instance, the actual compilation problem I encountered). Others seem to feel the same way: <http://stackoverflow.com/questions/484592/overriding-public-virtual-functions-with-private-functions-in-c>. That article (in part) refers to <https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public>.

So how do you come down on the opposite side of these opinions? What's being communicated by making public methods private in the derived class?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161024/9687818d/attachment.html>