<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=163777#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: switch to use subclasses for NetworkSession and NetworkDataTask implementations"
href="https://bugs.webkit.org/show_bug.cgi?id=163777">bug 163777</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163777#c12">comment #12</a>)
<span class="quote">> > I think these overrides should remain private.
>
> I'm curious about your desire for this. This is an idiom that I've not seen
> used before. It seems to me that it could be problematic (for instance, the
> actual compilation problem I encountered). Others seem to feel the same way:
> <<a href="http://stackoverflow.com/questions/484592/overriding-public-virtual">http://stackoverflow.com/questions/484592/overriding-public-virtual</a>-
> functions-with-private-functions-in-c>. That article (in part) refers to
> <<a href="https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public">https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public</a>>.
>
> So how do you come down on the opposite side of these opinions? What's being
> communicated by making public methods private in the derived class?</span >
In this particular case those methods are pure virtual an expected to be used by NetworkDataTask users who don't know about Soup/Cocoa implementations. Those overrides are providing the implementation for the base class. I'm pretty sure we do this in WebKit, but still, I don't have a strong opinion, we can make them public if you think it's better solution.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>