[Webkit-unassigned] [Bug 163722] [GTK] Avoid including egl.h headers in internal headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163722

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 292166 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292166&action=review
> 
> > Source/WebCore/platform/graphics/egl/GLContextEGLWayland.cpp:79
> > +    return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(wlSurface), window));
> 
> Is std::make_unique<>() usable here?
> 
> > Source/WebCore/platform/graphics/egl/GLContextEGLX11.cpp:99
> > +    return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(pixmap)));
> 
> Is std::make_unique<>() usable here?

Nope, constructors are private to ensure only the create methods can create instances.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161020/b3efff21/attachment.html>