[Webkit-unassigned] [Bug 163722] [GTK] Avoid including egl.h headers in internal headers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 20 05:29:24 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163722

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292166|review?                     |review+
              Flags|                            |

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 292166
  --> https://bugs.webkit.org/attachment.cgi?id=292166
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292166&action=review

> Source/WebCore/platform/graphics/egl/GLContextEGLWayland.cpp:79
> +    return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(wlSurface), window));

Is std::make_unique<>() usable here?

> Source/WebCore/platform/graphics/egl/GLContextEGLX11.cpp:99
> +    return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(pixmap)));

Is std::make_unique<>() usable here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161020/d536a97f/attachment.html>


More information about the webkit-unassigned mailing list