<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Avoid including egl.h headers in internal headers"
href="https://bugs.webkit.org/show_bug.cgi?id=163722#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Avoid including egl.h headers in internal headers"
href="https://bugs.webkit.org/show_bug.cgi?id=163722">bug 163722</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163722#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=292166&action=diff" name="attach_292166" title="Patch">attachment 292166</a> <a href="attachment.cgi?id=292166&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=292166&action=review">https://bugs.webkit.org/attachment.cgi?id=292166&action=review</a>
>
> > Source/WebCore/platform/graphics/egl/GLContextEGLWayland.cpp:79
> > + return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(wlSurface), window));
>
> Is std::make_unique<>() usable here?
>
> > Source/WebCore/platform/graphics/egl/GLContextEGLX11.cpp:99
> > + return std::unique_ptr<GLContextEGL>(new GLContextEGL(platformDisplay, context, surface, WTFMove(pixmap)));
>
> Is std::make_unique<>() usable here?</span >
Nope, constructors are private to ensure only the create methods can create instances.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>