[Webkit-unassigned] [Bug 163204] NetworkSession: NetworkDataTask is leaked if download finishes in didReceiveResponse completion handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163204

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 291090 [details]
> Try to fix mac builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291090&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        NetworkDataTask, so that the download manager can check the task state after the co,pletion handler and return
> 
> completion
> 
> > Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:426
> > +    ASSERT_NOT_REACHED();
> > +    return State::Running;
> 
> I know this should be impossible and doesn't matter, but let's default to
> Completed in this case so we won't do anything.

Good point

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161010/778780a7/attachment.html>