[Webkit-unassigned] [Bug 163204] NetworkSession: NetworkDataTask is leaked if download finishes in didReceiveResponse completion handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 09:21:48 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163204

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291090|review?                     |review+
              Flags|                            |

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 291090
  --> https://bugs.webkit.org/attachment.cgi?id=291090
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=291090&action=review

> Source/WebKit2/ChangeLog:11
> +        NetworkDataTask, so that the download manager can check the task state after the co,pletion handler and return

completion

> Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:426
> +    ASSERT_NOT_REACHED();
> +    return State::Running;

I know this should be impossible and doesn't matter, but let's default to Completed in this case so we won't do anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161010/0283cc39/attachment.html>


More information about the webkit-unassigned mailing list