<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: NetworkDataTask is leaked if download finishes in didReceiveResponse completion handler"
href="https://bugs.webkit.org/show_bug.cgi?id=163204#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkSession: NetworkDataTask is leaked if download finishes in didReceiveResponse completion handler"
href="https://bugs.webkit.org/show_bug.cgi?id=163204">bug 163204</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163204#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=291090&action=diff" name="attach_291090" title="Try to fix mac builds">attachment 291090</a> <a href="attachment.cgi?id=291090&action=edit" title="Try to fix mac builds">[details]</a></span>
> Try to fix mac builds
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=291090&action=review">https://bugs.webkit.org/attachment.cgi?id=291090&action=review</a>
>
> > Source/WebKit2/ChangeLog:11
> > + NetworkDataTask, so that the download manager can check the task state after the co,pletion handler and return
>
> completion
>
> > Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:426
> > + ASSERT_NOT_REACHED();
> > + return State::Running;
>
> I know this should be impossible and doesn't matter, but let's default to
> Completed in this case so we won't do anything.</span >
Good point</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>