[Webkit-unassigned] [Bug 161481] [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161481

--- Comment #14 from Gustavo Noronha (kov) <gns at gnome.org> ---
(In reply to comment #11)
> (In reply to comment #9)
> > While the patch from bug 161135 applies along with this one, it does disable
> > this one which I think is undesirable. The result of having both applied
> > would be dbus-run-session be used every time it is available. This solution
> > is a better one, so I'd recommend just going with it, if we can fix the
> > threading concerns.
> 
> I'm not sure this patch solves the same problem. The bus started by
> WebKitTestBus::run() will be leaked if the test crashes, because
> ~WebKitTestBus() won't be called in that case. So, we can leave this code as
> fallback when dbus-run-session is not present, or when tests are run
> manually (without using run-gtk-tests), something that I do a lot. When
> dbus-run-session is present we simply set m_address, I don't think the
> patches are mutually exclusive.

I thought GTestDBus handled cleaning up the dbus daemon process even on crashes? But if you think it's useful to have both and ok to have dbus-run-session used when present I'll go ahead and land it =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161102/499c4bb0/attachment.html>